(Migrated) Oddity in requests

(This message has been automatically imported from the retired mailing list)

zato patches the ‘requests’ library, but there’s something I don’t
understand:

-def session():
+def session(*args, **kwargs):
""“Returns a :class:Session for context-management.”""

  return Session()

This is required because of the following code in
./code/zato-server/src/zato/server/connection/http_soap/outgoing.py

     self.session = 

self.requests_module.session(pool_maxsize=self.config[‘pool_size’])

But why pass the argument “pool_maxsize” if you are only going to throw
it away? I think maybe you meant to do the following:

  return Session(*args, **kwargs)

Regards,

Brian.